----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32019/#review76644 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetBytes.java <https://reviews.apache.org/r/32019/#comment124228> At a "micro" level, this and the other change look good. Did you spot it in code reading? Or, in the hash results being poor? The research paper would take time to study. How would one write tests for Cuckoo? - Matt McCline On March 13, 2015, 2:46 a.m., Alexander Pivovarov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32019/ > ----------------------------------------------------------- > > (Updated March 13, 2015, 2:46 a.m.) > > > Review request for hive, Ashutosh Chauhan, Gopal V, Sergey Shelukhin, and > Vikram Dixit Kumaraswamy. > > > Bugs: HIVE-9950 > https://issues.apache.org/jira/browse/HIVE-9950 > > > Repository: hive-git > > > Description > ------- > > HIVE-9950 fix rehash in CuckooSetBytes and CuckooSetLong > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetBytes.java > fe75ce3d3b14b84d023612c00554729e793dc677 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetDouble.java > 5897c92a2022fea4e4453b2807fc7b3b364e2282 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetLong.java > 5779fb35d7ffbc67917cdcd66b1c57baa3e2bff3 > > Diff: https://reviews.apache.org/r/32019/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pivovarov > >
