----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32286/#review77276 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCount.java <https://reviews.apache.org/r/32286/#comment125158> minor nit - replace tab with spaces trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java <https://reviews.apache.org/r/32286/#comment125162> minor whitespace removal Just a couple of minor whitespace issues, but I think the changes make sense. Can you update the patch and re-upload so we can see the pre-commit failures again? - Jason Dere On March 20, 2015, 6:06 a.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32286/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 6:06 a.m.) > > > Review request for hive and Jason Dere. > > > Repository: hive > > > Description > ------- > > HIVE-9767 Fixes in Hive UDF to be usable in Pig > > > Diffs > ----- > > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java > 1661840 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFContextNGrams.java > 1661840 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCount.java > 1661840 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFEWAHBitmap.java > 1661840 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java > 1661840 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java > 1661840 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java > 1661840 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFnGrams.java > 1661840 > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCase.java > 1661840 > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIn.java > 1661840 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNamedStruct.java > 1661840 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java > 1661840 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFStack.java > 1661840 > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NGramEstimator.java > 1661840 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NumericHistogram.java > 1661840 > > Diff: https://reviews.apache.org/r/32286/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Dai > >
