----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32374/#review77767 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFJson.java <https://reviews.apache.org/r/32374/#comment125968> what is the reason for the pathString.length() == 2 check in here? I'm assuming the jsonPath logic later on is able to take care of any cases handled here? Or is it simply to try to quickly handle this particular error case? If this is the reason, I would say just let the later logic handle it, I would not think this would be a common source of user error for this function. ql/src/java/org/apache/hadoop/hive/ql/udf/UDFJson.java <https://reviews.apache.org/r/32374/#comment125964> I don't think it should blindly return the jsonString without parsing in this case. When jsonString is invalid JSON, I would think the behavior should be to return NULL. - Jason Dere On March 25, 2015, 2:33 a.m., Alexander Pivovarov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32374/ > ----------------------------------------------------------- > > (Updated March 25, 2015, 2:33 a.m.) > > > Review request for hive, Jason Dere and namit jain. > > > Bugs: HIVE-1575 > https://issues.apache.org/jira/browse/HIVE-1575 > > > Repository: hive-git > > > Description > ------- > > HIVE-1575 get_json_object does not support JSON array at the root level > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFJson.java > 781286613d1b939f684e7be95341adaeeca0c60e > ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFJson.java PRE-CREATION > ql/src/test/queries/clientpositive/udf_get_json_object.q > 05f7f5a9811bc028565d88f08fc36058cd85148d > ql/src/test/results/clientpositive/udf_get_json_object.q.out > 51f0c1510d101189e281f40ffd7bcd7f1ed97c84 > > Diff: https://reviews.apache.org/r/32374/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pivovarov > >
