> On March 27, 2015, 6:08 p.m., Mohit Sabharwal wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMonthsBetween.java, > > line 129 > > <https://reviews.apache.org/r/32489/diff/2-3/?file=906532#file906532line129> > > > > static?
IMHO in OOP it's recommended not to use static methods becasue they can not be overwritten by child classes > On March 27, 2015, 6:08 p.m., Mohit Sabharwal wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java, line 507 > > <https://reviews.apache.org/r/32489/diff/3/?file=907259#file907259line507> > > > > 19...a comment on where this comes from would be great added comment // lets be strict here and // support only exact 10 char string for short date format - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32489/#review78088 ----------------------------------------------------------- On March 27, 2015, 12:58 a.m., Alexander Pivovarov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32489/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 12:58 a.m.) > > > Review request for hive and Jason Dere. > > > Bugs: HIVE-9518 > https://issues.apache.org/jira/browse/HIVE-9518 > > > Repository: hive-git > > > Description > ------- > > HIVE-9518 Implement MONTHS_BETWEEN aligned with Oracle one > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java > 2476e832b8b7101971ea2226368aa82633b7e7d1 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java > ce981232382e993c7c9d640efe9b2d21f70a0ed4 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMonthsBetween.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFMonthsBetween.java > PRE-CREATION > ql/src/test/queries/clientpositive/udf_months_between.q PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out > 22091d06241218a5c0ee21d6ee6be00a71706971 > ql/src/test/results/clientpositive/udf_months_between.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/32489/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pivovarov > >
