----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32809/ -----------------------------------------------------------
(Updated April 7, 2015, 6:18 p.m.) Review request for hive, Ashutosh Chauhan and John Pullokkaran. Changes ------- thanks for Swarnim Kulkarni's comments. I tried to answer and address them. Repository: hive-git Description ------- Since we don't allow users to query column names with dot in the middle such as emp.no, don't allow users to create tables with such columns that cannot be queried. Fix the documentation to reflect this fix. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 2e583da ql/src/test/org/apache/hadoop/hive/ql/parse/TestUnpermittedCharsInColumnNameCreateTableNegative.java PRE-CREATION Diff: https://reviews.apache.org/r/32809/diff/ Testing ------- Thanks, pengcheng xiong