----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32901/#review79309 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java <https://reviews.apache.org/r/32901/#comment128564> Is this needed to be done? I thought thrift objects default this to false. ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java <https://reviews.apache.org/r/32901/#comment128565> I would think including a WARN or atleast a DEBUG here will be helpful for debugging. - Swarnim Kulkarni On April 7, 2015, 10:05 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32901/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 10:05 p.m.) > > > Review request for hive, Ashutosh Chauhan and Prasanth_J. > > > Bugs: HIVE-10226 > https://issues.apache.org/jira/browse/HIVE-10226 > > > Repository: hive-git > > > Description > ------- > > Re-use the long stats for Date column stats, using the days since epoch value > as the long value. > > > Diffs > ----- > > metastore/if/hive_metastore.thrift 57bce0c > > metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionColumnStatistics.java > 1666dc3 > > metastore/src/model/org/apache/hadoop/hive/metastore/model/MTableColumnStatistics.java > bce9f0f > ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 0c46b00 > ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java > b85282c > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java > 1662696 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java > 363039b > ql/src/test/queries/clientpositive/compute_stats_date.q PRE-CREATION > ql/src/test/results/clientpositive/compute_stats_date.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/32901/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
