> On April 8, 2015, 9:22 a.m., chengxiang li wrote: > > itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java, > > line 73 > > <https://reviews.apache.org/r/32920/diff/3/?file=920776#file920776line73> > > > > This static variables is specified for expressions of 2 paramater > > operator, i think we can move it to each setup() method.
Thank you for your comments. These variables are reused and will be initialized in setup method of the VectorizationBench. - cheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/#review79327 ----------------------------------------------------------- On April 8, 2015, 8:42 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32920/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 8:42 a.m.) > > > Review request for hive and chengxiang li. > > > Repository: hive-git > > > Description > ------- > > Add microbenchmark tool to show performance improvement by JMH > > > Diffs > ----- > > > itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/32920/diff/ > > > Testing > ------- > > > Thanks, > > cheng xu > >
