----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33680/#review82091 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/33680/#comment132758> tiny nit: you don't need to capitalize metastore (but this isn't worth a separate patch, "Metastore" is okay too, so only change it if you're making other changes) - Lefty Leverenz On April 29, 2015, 11:35 a.m., Reuben Kuhnert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33680/ > ----------------------------------------------------------- > > (Updated April 29, 2015, 11:35 a.m.) > > > Review request for hive and Sergio Pena. > > > Bugs: HIVE-9365 > https://issues.apache.org/jira/browse/HIVE-9365 > > > Repository: hive-git > > > Description > ------- > > HIVE-9365: The Metastore should take port configuration from hive-site.xml > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > c9ee423cf73706feb2774dacca9fc7b94fe80617 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 3f267ff0eb20560c36a19b74353f9d6749c8b333 > > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetastoreCli.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33680/diff/ > > > Testing > ------- > > Unit tests attached. Also tested locally. > > > Thanks, > > Reuben Kuhnert > >
