> On April 30, 2015, 9:29 p.m., Vaibhav Gumashta wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 403 > > <https://reviews.apache.org/r/31146/diff/3/?file=946416#file946416line403> > > > > Can you add a small comment here to indicate that 0s means this config > > is disabled? You might want to add the new config to HiveConf.metaVars as > > well.
I have rephrased the whole description. Please let me know if this looks ok. Good catch, I forgot about the metaVars. - Thiruvel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31146/#review82203 ----------------------------------------------------------- On April 30, 2015, 11:33 p.m., Thiruvel Thirumoolan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31146/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 11:33 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-9508: MetaStore client socket connection should have a lifetime > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 72e4ff2 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 130fd67 > > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java > 5ce58ee > > Diff: https://reviews.apache.org/r/31146/diff/ > > > Testing > ------- > > 1. Added a unit test case. > 2. Tested on a live deployment with the fix. The client reconnected after 5 > minutes. > > > Thanks, > > Thiruvel Thirumoolan > >
