----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33806/#review82383 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java <https://reviews.apache.org/r/33806/#comment133119> Hive uses the exact class name in the imports instead of *. Also, seems java.util.function is a java8 functionality. I tried to compile it with java7, but it fails: [ERROR] /opt/local/hive/upstream/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:[22,26] package java.util.function does not exist [ERROR] /opt/local/hive/upstream/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:[234,59] cannot find symbol symbol: class Predicate location: class org.apache.hadoop.hive.ql.parse.ParseUtils [ERROR] /opt/local/hive/upstream/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:[226,53] cannot find symbol symbol: class Predicate location: class org.apache.hadoop.hive.ql.parse.ParseUtils - Sergio Pena On May 4, 2015, 1:55 p.m., Reuben Kuhnert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33806/ > ----------------------------------------------------------- > > (Updated May 4, 2015, 1:55 p.m.) > > > Review request for hive and Sergio Pena. > > > Bugs: HIVE-10190 > https://issues.apache.org/jira/browse/HIVE-10190 > > > Repository: hive-git > > > Description > ------- > > HIVE-10190: CBO: AST mode checks for TABLESAMPLE with > AST.toString().contains("TOK_TABLESPLITSAMPLE") > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java > 7614463525262f01375c1336e89a18670862bb7d > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java > 373429cbf666f1b19828c532aea3c07f08f95e1a > > Diff: https://reviews.apache.org/r/33806/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Reuben Kuhnert > >
