> On May 6, 2015, 4:09 a.m., Prasanth_J wrote: > > serde/src/test/org/apache/hadoop/hive/serde2/VerifyFast.java, line 250 > > <https://reviews.apache.org/r/33877/diff/1/?file=950807#file950807line250> > > > > Isn't it supposed to append lengths here?
I think it is more informative if failure error message has both arrays content(not just arrays lenght). - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33877/#review82631 ----------------------------------------------------------- On May 6, 2015, 3:53 a.m., Alexander Pivovarov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33877/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 3:53 a.m.) > > > Review request for hive and Prasanth_J. > > > Bugs: HIVE-10618 > https://issues.apache.org/jira/browse/HIVE-10618 > > > Repository: hive-git > > > Description > ------- > > HIVE-10618 Fix invocation of toString on byteArray in VerifyFast (250, 254) > > > Diffs > ----- > > serde/src/test/org/apache/hadoop/hive/serde2/VerifyFast.java > a3472ad7f565becd2d617289323f18b9df989146 > > Diff: https://reviews.apache.org/r/33877/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pivovarov > >
