----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33882/#review82917 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExpandDistinctAggregatesRule.java <https://reviews.apache.org/r/33882/#comment133747> Instead of getting col origins on every arg; if we wait till this optimization's conditions are met. Then we need to get column origins for atmost one column. - John Pullokkaran On May 6, 2015, 7:25 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33882/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 7:25 a.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-10568 > https://issues.apache.org/jira/browse/HIVE-10568 > > > Repository: hive-git > > > Description > ------- > > Speed-up count(distinct c1) > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExpandDistinctAggregatesRule.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 49ad6ad > ql/src/test/results/clientpositive/tez/limit_pushdown.q.out 7038b4d > ql/src/test/results/clientpositive/tez/mrr.q.out ac5ac5c > ql/src/test/results/clientpositive/tez/vector_count_distinct.q.out f1da471 > ql/src/test/results/clientpositive/tez/vectorization_limit.q.out d815938 > ql/src/test/results/clientpositive/tez/vectorized_distinct_gby.q.out > 90c9934 > > Diff: https://reviews.apache.org/r/33882/diff/ > > > Testing > ------- > > Existing tests. > > > Thanks, > > Ashutosh Chauhan > >