----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34040/ -----------------------------------------------------------
Review request for hive. Repository: hive-git Description ------- This is the first step to add sum() support for "rows between x preceding and y preceding" and "rows between x following and y following" windowing. This is just a refactoring without affecting the functionality by passing WindowFrameDef instead of passing # of preceding and # of following. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java 00b43c6 ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/BoundaryDef.java f692fa2 ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowFrameDef.java e08bdd5 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 12a327f ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFFirstValue.java f679387 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLastValue.java e099154 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMax.java a153818 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStreamingEvaluator.java d68c085 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java ffb7093 ql/src/test/org/apache/hadoop/hive/ql/udaf/TestStreamingSum.java a331e66 Diff: https://reviews.apache.org/r/34040/diff/ Testing ------- Testing has been done and the unit tests failures seem to be unrelated. https://issues.apache.org/jira/browse/HIVE-10643 Thanks, Aihua Xu
