Re: Review Request 34495: HIVE-10678 : In QTestGenTask.execute() we should not throw an exception right away if we are unable to clean any old files

Wed, 20 May 2015 14:42:07 -0700 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34495/
-----------------------------------------------------------

(Updated May 20, 2015, 9:41 p.m.)


Review request for hive and Xuefu Zhang.


Changes
-------

Thanks Xuefu for the comment, I have addressed it in the new patch.


Repository: hive-git


Description
-------

Currently in QTestGenTask.execute(), we have code like :
       if (logFile != null) {
         File lf = new File(logFile);
         if (lf.exists()) {
           if (!lf.delete()) {
             throw new Exception("Could not delete log file " + 
lf.getCanonicalPath());
         }
If the log file gets locked due to some other process, it throws the above 
exception and short circuits the entire test suite. We should provide a 
mechanism to generate alternative new log files/temporary files whenever 
possible to avoid unit test failures.


Diffs (updated)
-----

  ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 60c7764 

Diff: https://reviews.apache.org/r/34495/diff/


Testing
-------


Thanks,

Hari Sankar Sivarama Subramaniyan

Reply via email to