> On May 20, 2015, 8:45 p.m., Alexander Pivovarov wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetStructObjectInspector.java, > > line 207 > > <https://reviews.apache.org/r/34473/diff/1/?file=965270#file965270line207> > > > > you can use > > final ArrayList<Object> list = new > > ArrayList<Object>(Collections.nCopies(fields.size(), null)); > > instead
I don't think so because only in the insert statement, we can't understand how to inspect the row object until creating parquet writer. This is why I create the new constructor in ParquetStructObjectInspector. Thank yoU! - cheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34473/#review84574 ----------------------------------------------------------- On May 20, 2015, 2:54 p.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34473/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 2:54 p.m.) > > > Review request for hive, Alan Gates and Sergio Pena. > > > Bugs: HIVE-10749 > https://issues.apache.org/jira/browse/HIVE-10749 > > > Repository: hive-git > > > Description > ------- > > Implement the insert statement for parquet format. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/MapredParquetInputFormat.java > 000eb38 > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/MapredParquetOutputFormat.java > 8380117 > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/VectorizedParquetInputFormat.java > 4e1820c > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/acid/ParquetRawRecordMerger.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/acid/ParquetRecordUpdater.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveSchemaConverter.java > 43c772f > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetRecordReaderWrapper.java > 0a5edbb > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetStructObjectInspector.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/ParquetRecordWriterWrapper.java > 0d32e49 > > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/AbstractTestParquetDirect.java > 5f7f597 > > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/acid/TestParquetRecordUpdater.java > PRE-CREATION > ql/src/test/queries/clientpositive/acid_parquet_insert.q PRE-CREATION > ql/src/test/results/clientpositive/acid_parquet_insert.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/34473/diff/ > > > Testing > ------- > > Newly added qtest and UT passed locally > > > Thanks, > > cheng xu > >
