----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34897/ -----------------------------------------------------------
(Updated June 17, 2015, 5:54 p.m.) Review request for hive and Jesús Camacho Rodríguez. Changes ------- Address all the comments. Repository: hive-git Description ------- in ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java, line 477, when aliases contains empty string "" and key is an empty string "" too, it assumes that aliases contains key. This will trigger incorrect PPD. To reproduce it, apply the HIVE-10455 and run cbo_subq_notin.q. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 9c21238 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverterPostProc.java e7c8342 Diff: https://reviews.apache.org/r/34897/diff/ Testing ------- Thanks, pengcheng xiong
