----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35897/ -----------------------------------------------------------
Review request for hive. Bugs: HIVE-11032 https://issues.apache.org/jira/browse/HIVE-11032 Repository: hive-git Description ------- HIVE-11032: Enable more tests for grouping by skewed data [Spark Branch] All tests with hive.groupby.skewindata set pass with Spark except explainuser_1.q, which has set hive.explain.user=true; set and this feature (user friendly explain output) is not supported for Spark yet. git grep "hive.groupby.skewindata" | grep ".q:" | perl -pe 's@:set hive.groupby.skewindata.*@@g' | sort Diffs ----- itests/src/test/resources/testconfiguration.properties 7b7559a9590803f2528a24180a962013881cba1b ql/src/test/results/clientnegative/spark/groupby2_multi_distinct.q.out PRE-CREATION ql/src/test/results/clientnegative/spark/groupby3_map_skew_multi_distinct.q.out PRE-CREATION ql/src/test/results/clientnegative/spark/groupby3_multi_distinct.q.out PRE-CREATION ql/src/test/results/clientnegative/spark/groupby_grouping_sets7.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby1_map.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby1_map_nomap.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby1_map_skew.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby1_noskew.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby2_map.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby2_map_multi_distinct.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby2_map_skew.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby2_noskew.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby2_noskew_multi_distinct.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby4_map.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby4_map_skew.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby4_noskew.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby5.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby5_map.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby5_map_skew.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby5_noskew.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby6.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby6_map.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby6_map_skew.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby6_noskew.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby_grouping_id2.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby_ppr_multi_distinct.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/groupby_resolution.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/nullgroup.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/nullgroup2.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/nullgroup4.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/nullgroup4_multi_distinct.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/temp_table_gb1.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/udaf_collect_set.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/udf_max.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/udf_min.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/udf_percentile.q.out PRE-CREATION Diff: https://reviews.apache.org/r/35897/diff/ Testing ------- cat postiveqtests.txt | xargs -n 20 | perl -pe 's@ @,@g' | while read -r line; do command mvn test -Dtest=TestSparkCliDriver -Phadoop-2 -Dqfile=$line -Dtest.output.overwrite=true; done cat negativeqtests.txt | xargs -n 20 | perl -pe 's@ @,@g' | while read -r line; do command mvn test -Dtest=TestNegativeSparkCliDriver -Phadoop-2 -Dqfile=$line -Dtest.output.overwrite=true; done Thanks, Mohit Sabharwal