----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33890/#review94910 -----------------------------------------------------------
Ship it! Ship It! - Amareshwari Sriramadasu On Aug. 11, 2015, 7:18 a.m., Akshay Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33890/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 7:18 a.m.) > > > Review request for hive and Amareshwari Sriramadasu. > > > Bugs: HIVE-10435 > https://issues.apache.org/jira/browse/HIVE-10435 > > > Repository: hive-git > > > Description > ------- > > SessionManager in CLIService creates and keeps track of HiveSession. > Right now, it creates HiveSessionImpl which is one implementation of > HiveSession. This improvement request is to make it pluggable through a > configuration so that other implementations can be passed. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fe4eb9f > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > c46bbce > > service/src/test/org/apache/hive/service/cli/session/TestPluggableHiveSessionImpl.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33890/diff/ > > > Testing > ------- > > Newly added unit test passed. > > > Thanks, > > Akshay Goyal > >
