> On Aug. 18, 2015, 6:06 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java, > > line 467 > > <https://reviews.apache.org/r/37563/diff/1/?file=1042755#file1042755line467> > > > > Can you make sure that (Byte)inputFieldTag).intValue() is >= 0 && < > > fieldConverters.size(). If not, you can either throw an exception or NULL > > based on how you handle extra tags.
Ah..good call. I think we only need to care about extra fields in the input as that is what we are parsing the tags from. I'll get this updated. - Swarnim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37563/#review95749 ----------------------------------------------------------- On Aug. 18, 2015, 3:35 a.m., Swarnim Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37563/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 3:35 a.m.) > > > Review request for hive and Hari Sankar Sivarama Subramaniyan. > > > Repository: hive-git > > > Description > ------- > > HIVE-10697 Fix for ObjectInspectorConvertors#UnionConvertor doing a faulty > conversion > > > Diffs > ----- > > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java > 8ef8ce1736d50f0f9163cd5e3fd00ddd4bd810da > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SettableUnionObjectInspector.java > a64aee074d05a14c3c72079ff960039811936419 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java > d1b11e82730e57f6894145478aae7c0c0c26e518 > > serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java > 11852833577149152cefaef50ee49328733c9dde > > Diff: https://reviews.apache.org/r/37563/diff/ > > > Testing > ------- > > Unit tests added. > > > Thanks, > > Swarnim Kulkarni > >
