----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37591/#review95789 -----------------------------------------------------------
It makes sense, but I just had some basic questions. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java (line 90) <https://reviews.apache.org/r/37591/#comment150918> Seems a little risky to me, what if there are some bad GC pause? If it's fully-inited it should get notified , so how about a longer timeout? serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java (line 165) <https://reviews.apache.org/r/37591/#comment150917> Very basic question I'm sure you thought of, why can't we synchronize the entire init() method? I assume this method will init all the children. Then we won't need the isFullyInit methods? - Szehon Ho On Aug. 18, 2015, 9:51 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37591/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 9:51 p.m.) > > > Review request for hive. > > > Bugs: HIVE-11586 > https://issues.apache.org/jira/browse/HIVE-11586 > > > Repository: hive-git > > > Description > ------- > > Made ObjectInspectorFactory.getReflectionObjectInspector thread-safe. When it > returns, the object inspector is fully initialized. > > > Diffs > ----- > > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java > 97bb715 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java > 78e6066 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ThriftUnionObjectInspector.java > 600abbb > > serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestReflectionObjectInspectors.java > e2408c6 > > Diff: https://reviews.apache.org/r/37591/diff/ > > > Testing > ------- > > Unit test > > > Thanks, > > Jimmy Xiang > >
