----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37333/#review96189 -----------------------------------------------------------
Ship it! After the fix to the log line being an exception. ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java (line 472) <https://reviews.apache.org/r/37333/#comment151511> Should be an error (IllegalStateException), instead of just logging this. - Siddharth Seth On Aug. 11, 2015, 12:49 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37333/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 12:49 a.m.) > > > Review request for hive. > > > Bugs: HIVE-11515 > https://issues.apache.org/jira/browse/HIVE-11515 > > > Repository: hive-git > > > Description > ------- > > Even after HIVE-9976, I could see race condition in DPP sometimes. Hard to > reproduce but it seemed related to the fact that prune() is called by > thread-pool. With some delay in queue, events from fast tasks are arrived > before prune() is called. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java > 7abd94d > > Diff: https://reviews.apache.org/r/37333/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
