----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37706/#review96378 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAesBase.java (line 57) <https://reviews.apache.org/r/37706/#comment151709> Can you move this initialization during initialize()? I believe all builtin UDFs are instantiated during static initialzation. A failure here means Hive will fail to start up, whereas failing during initialize() would simply cause a query using this UDF to fail. - Jason Dere On Aug. 24, 2015, 5:22 a.m., Alexander Pivovarov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37706/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 5:22 a.m.) > > > Review request for hive and Jason Dere. > > > Bugs: HIVE-11593 > https://issues.apache.org/jira/browse/HIVE-11593 > > > Repository: hive-git > > > Description > ------- > > HIVE-11593 Add aes_encrypt and aes_decrypt UDFs > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java > 4c1c53eff84f7e855fcd344aba16012fc1b31d1a > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAesBase.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAesDecrypt.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAesEncrypt.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFParamUtils.java > cdbc6eae96c850ed46806e79c6f661c0f406d0e8 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAesDecrypt.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAesEncrypt.java > PRE-CREATION > ql/src/test/queries/clientpositive/udf_aes_decrypt.q PRE-CREATION > ql/src/test/queries/clientpositive/udf_aes_encrypt.q PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out > 540079bc8787547cafe747f5855f41f5a829177c > ql/src/test/results/clientpositive/udf_aes_decrypt.q.out PRE-CREATION > ql/src/test/results/clientpositive/udf_aes_encrypt.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/37706/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pivovarov > >
