----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37930/#review97100 -----------------------------------------------------------
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseInputFormatUtil.java (line 235) <https://reviews.apache.org/r/37930/#comment152847> typo hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseInputFormatUtil.java (line 244) <https://reviews.apache.org/r/37930/#comment152846> that seems brittle, can you use actual class objects? - Sergey Shelukhin On Aug. 31, 2015, 5:51 a.m., Swarnim Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37930/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 5:51 a.m.) > > > Review request for hive, Ashutosh Chauhan, Gopal V, Navis Ryu, and Sergey > Shelukhin. > > > Repository: hive-git > > > Description > ------- > > HIVE-11609 Fix filter logic for hbase scans via composite keys > > > Diffs > ----- > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseScanRange.java > 8b6432161281bb87e536a164d056b0d1599d7428 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseInputFormatUtil.java > c0020706477df48d60937c64db2af9ffff08665c > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java > 8e72759acd939e8650e4763e55240f49de578770 > > hbase-handler/src/test/org/apache/hadoop/hive/hbase/SampleHBaseKeyFactory3.java > 712725f208f4b2c9cc166750509c25859518ec3e > hbase-handler/src/test/results/positive/hbase_custom_key3.q.out > 25032cc36557245b0ae21c80ba66c9866b9d143d > ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java > 98bce9649b1cddd44be7cd0f9c529985e42874b8 > > Diff: https://reviews.apache.org/r/37930/diff/ > > > Testing > ------- > > > Thanks, > > Swarnim Kulkarni > >
