----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37985/#review97385 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 288) <https://reviews.apache.org/r/37985/#comment153268> Any reason we are not doing this right away? The reason I ask is the sarg object might be huge and since INFO is the default log level, this probably would add considerable load to the hive logs correct? ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1414) <https://reviews.apache.org/r/37985/#comment153272> Nit: Could use parameter substitution instead of concatenating it ourselves. ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1423) <https://reviews.apache.org/r/37985/#comment153273> Nit: Fix formatting. ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1427) <https://reviews.apache.org/r/37985/#comment153274> Should we check if filterColumns is not empty to avoid a ArrayindexOutOfBounds serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java (line 146) <https://reviews.apache.org/r/37985/#comment153275> Should we log a bug for this? - Swarnim Kulkarni On Sept. 2, 2015, 1:06 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37985/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 1:06 a.m.) > > > Review request for hive and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 05efc5f > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSerde.java 8beff4b > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java fcb3746 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ProjectionPusher.java > 4480600 > ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java > e034650 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java > 2dc15f9 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b809a23 > serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java > 10086c5 > > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java > 0778935 > > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java > d27ac16 > > Diff: https://reviews.apache.org/r/37985/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
