[
https://issues.apache.org/jira/browse/HIVE-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139038#comment-13139038
]
jirapos...@reviews.apache.org commented on HIVE-2278:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2595/#review2918
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java
<https://reviews.apache.org/r/2595/#comment6526>
In the example above, (hr='1', ds='2011-01-01') will work. It should not
work - it would be simpler if you check the order also
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java
<https://reviews.apache.org/r/2595/#comment6527>
add some comments
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java
<https://reviews.apache.org/r/2595/#comment6528>
1 for loop instead of 2 for loops
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java
<https://reviews.apache.org/r/2595/#comment6529>
I think there is a bug here - not sure
Why have a for loop - you are returning inside if anyway the first time ?
- namit
On 2011-10-28 18:28:45, Yongqiang He wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2595/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-28 18:28:45)
bq.
bq.
bq. Review request for hive and namit jain.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support archiving for multiple partitions if the table is partitioned by
multiple columns
bq.
bq.
bq. This addresses bug HIVE-2278.
bq. https://issues.apache.org/jira/browse/HIVE-2278
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/data/files/archive_corrupt.rc UNKNOWN
bq. trunk/metastore/if/hive_metastore.thrift 1188906
bq. trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.h
1188906
bq. trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.cpp
1188906
bq.
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java
1188906
bq.
trunk/metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php
1188906
bq. trunk/metastore/src/gen/thrift/gen-py/hive_metastore/constants.py
1188906
bq. trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_constants.rb
1188906
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1188906
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java
PRE-CREATION
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1188906
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1188906
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java
1188906
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java
1188906
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1188906
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1188906
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
1188906
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
1188906
bq. trunk/ql/src/test/queries/clientnegative/archive_insert1.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_insert2.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_insert3.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_insert4.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_multi1.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_multi2.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_multi3.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_multi4.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_multi5.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_multi6.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_multi7.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_partspec1.q
PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_partspec2.q
PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/archive_partspec3.q
PRE-CREATION
bq. trunk/ql/src/test/queries/clientpositive/archive_corrupt.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientpositive/archive_multi.q PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive1.q.out 1188906
bq. trunk/ql/src/test/results/clientnegative/archive2.q.out 1188906
bq. trunk/ql/src/test/results/clientnegative/archive_insert1.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_insert2.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_insert3.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_insert4.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_multi1.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_multi2.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_multi3.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_multi4.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_multi5.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_multi6.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_multi7.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_partspec1.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_partspec2.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/archive_partspec3.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientpositive/archive_corrupt.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientpositive/archive_multi.q.out
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2595/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Support archiving for multiple partitions if the table is partitioned by
multiple columns
bq.
bq.
bq. Thanks,
bq.
bq. Yongqiang
bq.
bq.
> Support archiving for multiple partitions if the table is partitioned by
> multiple columns
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-2278
> URL: https://issues.apache.org/jira/browse/HIVE-2278
> Project: Hive
> Issue Type: New Feature
> Reporter: Namit Jain
> Assignee: Marcin Kurczych
> Attachments: HIVE-2278.2.patch, HIVE-2278.3.patch, HIVE-2278.4.patch,
> HIVE-2278.5.patch, HIVE-2278.5.patch, HIVE-2278.6.patch, HIVE-2278.6.patch,
> HIVE-2278.7.patch, HIVE-2278.8.patch, archive_corrupt.rc, hive.2278.1.patch
>
>
> If a table is partitioned by ds,hr
> it should be possible to archive all the files in ds to reduce the number of
> files
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
