----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38768/#review100654 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java (line 315) <https://reviews.apache.org/r/38768/#comment157883> Shouldn't we fix the API to provide the stats in the same order as it was given? In this case cols are given in the same order as it appears in the table. - John Pullokkaran On Sept. 25, 2015, 6:37 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38768/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 6:37 p.m.) > > > Review request for hive. > > > Bugs: HIVE-11964 > https://issues.apache.org/jira/browse/HIVE-11964 > > > Repository: hive-git > > > Description > ------- > > The stats in hiveColStats should be ordered in that of the columns in > nonPartColIndxsThatRqrStats/nonPartColNamesThatRqrStats before being put in > the hiveColStatsMap > === > for (int i = 0; i < hiveColStats.size(); i++) { > hiveColStatsMap.put(nonPartColIndxsThatRqrStats.get(i), > hiveColStats.get(i)); > } > > Since hiveColStats = StatsUtils.getTableColumnStats(hiveTblMetadata, > hiveNonPartitionCols, nonPartColNamesThatRqrStats); might not return the > stats in same order as those in nonPartColNamesThatRqrStats. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java > 6c0bd25 > > Diff: https://reviews.apache.org/r/38768/diff/ > > > Testing > ------- > > Precommit tests > > > Thanks, > > Chaoyu Tang > >
