----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39142/#review101960 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 7679) <https://reviews.apache.org/r/39142/#comment159473> use LOG.warn here ? ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (line 1554) <https://reviews.apache.org/r/39142/#comment159475> Most of the details here in the comment could be moved to ObjectStore.unCacheDataNucleusClassLoaders so that its with the corresponding code. ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (line 1564) <https://reviews.apache.org/r/39142/#comment159476> use ObjectStore.class.getName() instead of string ? - Thejas Nair On Oct. 8, 2015, 7:49 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39142/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2015, 7:49 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-11499 > https://issues.apache.org/jira/browse/HIVE-11499 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-11499 > > > Diffs > ----- > > data/files/identity_udf.jar PRE-CREATION > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > 8ba2a12 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 8e32966 > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 77820ae > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 31f8ccf > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 56b0fae > > Diff: https://reviews.apache.org/r/39142/diff/ > > > Testing > ------- > > UT added. > > > Thanks, > > Vaibhav Gumashta > >
