----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39199/#review102683 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java (line 97) <https://reviews.apache.org/r/39199/#comment160435> this can run before the vectorizer and the rearrange code. or at least we should change the comments here in this or another jira. it doesn't look good to say "vect shoudl be last" and then have 2 more. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/VerifyTopNMemoryUsage.java (line 31) <https://reviews.apache.org/r/39199/#comment160436> a class level comment would be nice. can be done when you commit the change. ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java (line 487) <https://reviews.apache.org/r/39199/#comment160438> as in mr, consider moving it? ql/src/test/queries/clientpositive/topn.q (line 3) <https://reviews.apache.org/r/39199/#comment160434> Are you sure that this actually tests the code? Since the table you create is empty I'm not sure we'd even init the top n hash in the first place. - Gunther Hagleitner On Oct. 14, 2015, 6:10 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39199/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 6:10 p.m.) > > > Review request for hive, Ashutosh Chauhan and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > Please look at https://issues.apache.org/jira/browse/HIVE-12084 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/PTFTopNHash.java f93b420 > ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java e33c1d4 > ql/src/java/org/apache/hadoop/hive/ql/exec/TopNHash.java 484006a > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java > 49706b1 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/VerifyTopNMemoryUsage.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java a60527b > ql/src/test/queries/clientpositive/topn.q PRE-CREATION > ql/src/test/results/clientpositive/topn.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/39199/diff/ > > > Testing > ------- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
