----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38211/#review106333 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectSortTransposeRule.java (line 60) <https://reviews.apache.org/r/38211/#comment165065> You don't have to add collation to traitdef; HiveSortLimit does this for you automatically. Also the traits of sortnode from above should not be used; theoretically we should use the trait from project input. Practically Once sort is introduced only ordering trait can survive. - John Pullokkaran On Nov. 12, 2015, 10:47 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38211/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 10:47 a.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-11684 > https://issues.apache.org/jira/browse/HIVE-11684 > > > Repository: hive-git > > > Description > ------- > > Implement limit pushdown through outer join in CBO > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 7a8517b166185f5c501aceacc780dfab21de1c0a > itests/src/test/resources/testconfiguration.properties > 70f96da40c3c5b74e3ad2dd640321a2967cfcb86 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java > 90c2067e8279808fc0040e16d99a801b5d167eec > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveSortLimit.java > 82fdc0e04011aa585912ce5aae5e3245e5e5bb01 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectSortTransposeRule.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortJoinReduceRule.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortRemoveRule.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java > 728c5aa91f8d6eab6bcc2696c059ae1bdbeea689 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java > 715f24fc1872a54637a47bf80bb29e4a2e053779 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > de67b54a2c6cfd9bc4413ebf7f715e54c61b966f > ql/src/test/queries/clientpositive/limit_join_transpose.q PRE-CREATION > ql/src/test/queries/clientpositive/tez_dynpart_hashjoin_3.q PRE-CREATION > ql/src/test/results/clientpositive/limit_join_transpose.q.out PRE-CREATION > ql/src/test/results/clientpositive/tez/tez_dynpart_hashjoin_3.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/38211/diff/ > > > Testing > ------- > > Two new tests added: limit_join_transpose.q and tez_dynpart_hashjoin_3.q > (only Tez) > > > Thanks, > > Jesús Camacho Rodríguez > >
