[ 
https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141664#comment-13141664
 ] 

John Sichi commented on HIVE-2527:
----------------------------------

Got all kinds of failures, e.g. this one from dboutput.q in 
TestContribCliDriver:

{noformat}
    [junit] diff -a -I file: -I pfile: -I hdfs: -I /tmp/ -I invalidscheme: -I 
lastUp
dateTime -I lastAccessTime -I [Oo]wner -I CreateTime -I LastAccessTime -I 
Location -
I LOCATION ' -I transient_lastDdlTime -I last_modified_ -I 
java.lang.RuntimeExceptio
n -I at org -I at sun -I at java -I at junit -I Caused by: -I LOCK_QUERYID: -I 
LOCK_
TIME: -I grantTime -I [.][.][.] [0-9]* more -I job_[0-9]*_[0-9]* -I USING 'java 
-cp 
/data/users/jsichi/open/test-trunk/build/contrib/test/logs/contribclientpositive/dbo
utput.q.out 
/data/users/jsichi/open/test-trunk/contrib/src/test/results/clientpositi
ve/dboutput.q.out
    [junit] 48c48
    [junit] <   (TOK_QUERY (TOK_FROM (TOK_TABREF (TOK_TABNAME src))) 
(TOK_INSERT (TO
K_DESTINATION (TOK_DIR TOK_TMP_FILE)) (TOK_SELECT (TOK_SELEXPR (TOK_FUNCTION 
dboutpu
t (TOK_STRINGLITERALSEQUENCE 
'jdbc:derby:../build/test_dboutput_db;create=true') (TO
K_STRINGLITERALSEQUENCE '') (TOK_STRINGLITERALSEQUENCE '') 
(TOK_STRINGLITERALSEQUENC
E 'CREATE TABLE app_info ( kkey VARCHAR(255) NOT NULL, vvalue VARCHAR(255) NOT 
NULL,
 UNIQUE(kkey))'))) (TOK_SELEXPR (TOK_FUNCTION dboutput 
(TOK_STRINGLITERALSEQUENCE 'j
dbc:derby:../build/test_dboutput_db') (TOK_STRINGLITERALSEQUENCE '') 
(TOK_STRINGLITE
RALSEQUENCE '') (TOK_STRINGLITERALSEQUENCE 'INSERT INTO app_info (kkey,vvalue) 
VALUE
S (?,?)') (TOK_STRINGLITERALSEQUENCE '20') (TOK_STRINGLITERALSEQUENCE 'a'))) 
(TOK_SE
LEXPR (TOK_FUNCTION dboutput (TOK_STRINGLITERALSEQUENCE 
'jdbc:derby:../build/test_db
output_db') (TOK_STRINGLITERALSEQUENCE '') (TOK_STRINGLITERALSEQUENCE '') 
(TOK_STRIN
GLITERALSEQUENCE 'INSERT INTO app_info (kkey,vvalue) VALUES (?,?)') 
(TOK_STRINGLITER
ALSEQUENCE '20') (TOK_STRINGLITERALSEQUENCE 'b')))) (TOK_LIMIT 1)))
    [junit] ---
    [junit] >   (TOK_QUERY (TOK_FROM (TOK_TABREF (TOK_TABNAME src))) 
(TOK_INSERT (TO
K_DESTINATION (TOK_DIR TOK_TMP_FILE)) (TOK_SELECT (TOK_SELEXPR (TOK_FUNCTION 
dboutpu
t 'jdbc:derby:../build/test_dboutput_db;create=true' '' '' 'CREATE TABLE 
app_info ( 
kkey VARCHAR(255) NOT NULL, vvalue VARCHAR(255) NOT NULL, UNIQUE(kkey))')) 
(TOK_SELE
XPR (TOK_FUNCTION dboutput 'jdbc:derby:../build/test_dboutput_db' '' '' 'INSERT 
INTO
 app_info (kkey,vvalue) VALUES (?,?)' '20' 'a')) (TOK_SELEXPR (TOK_FUNCTION 
dboutput
 'jdbc:derby:../build/test_dboutput_db' '' '' 'INSERT INTO app_info 
(kkey,vvalue) VA
LUES (?,?)' '20' 'b'))) (TOK_LIMIT 1)))
    [junit] 129c129
    [junit] <   (TOK_QUERY (TOK_FROM (TOK_TABREF (TOK_TABNAME src))) 
(TOK_INSERT (TO
K_DESTINATION (TOK_DIR TOK_TMP_FILE)) (TOK_SELECT (TOK_SELEXPR (TOK_FUNCTION 
dboutpu
t (TOK_STRINGLITERALSEQUENCE 'jdbc:derby:../build/test_dboutput_db') 
(TOK_STRINGLITE
RALSEQUENCE '') (TOK_STRINGLITERALSEQUENCE '') (TOK_STRINGLITERALSEQUENCE 
'INSERT IN
TO app_info (kkey,vvalue) VALUES (?,?)') (TOK_TABLE_OR_COL key) 
(TOK_TABLE_OR_COL va
lue)))) (TOK_WHERE (< (TOK_TABLE_OR_COL key) 10))))
    [junit] ---
    [junit] >   (TOK_QUERY (TOK_FROM (TOK_TABREF (TOK_TABNAME src))) 
(TOK_INSERT (TO
K_DESTINATION (TOK_DIR TOK_TMP_FILE)) (TOK_SELECT (TOK_SELEXPR (TOK_FUNCTION 
dboutpu
t 'jdbc:derby:../build/test_dboutput_db' '' '' 'INSERT INTO app_info 
(kkey,vvalue) V
ALUES (?,?)' (TOK_TABLE_OR_COL key) (TOK_TABLE_OR_COL value)))) (TOK_WHERE (< 
(TOK_T
ABLE_OR_COL key) 10))))
    [junit] Exception: Client execution results failed with error code = 1
    [junit] See build/ql/tmp/hive.log, or try "ant test ... 
-Dtest.silent=false" to 
get more logs.
{noformat}



                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to