----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40500/#review107271 -----------------------------------------------------------
common/pom.xml (line 61) <https://reviews.apache.org/r/40500/#comment166298> Indent common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1856) <https://reviews.apache.org/r/40500/#comment166299> Typo service/src/java/org/apache/hive/service/cli/operation/OperationManager.java (line 65) <https://reviews.apache.org/r/40500/#comment166873> What do you think about having jsp code filter out operation that are not SQLOperation? Seems cleaner than maintaining a separate list in here. service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp (line 168) <https://reviews.apache.org/r/40500/#comment166304> One more comment, no need to put 'version', just 'When Hive version was compiled and by whom' - Szehon Ho On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40500/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 8:53 p.m.) > > > Review request for hive, Szehon Ho and Xuefu Zhang. > > > Bugs: HIVE-12338 > https://issues.apache.org/jira/browse/HIVE-12338 > > > Repository: hive-git > > > Description > ------- > > Added web UI to HS2. The UI is similar to those for other Hadoop components. > The default web UI port is set to 10002, which is configurable. It can be > disabled. Currently it shows active sessions and queries. It can also access > locals, metrics, and configuration. > > > Diffs > ----- > > common/pom.xml cd14581 > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85 > common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java > PRE-CREATION > common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION > common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION > common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION > pom.xml c6df4a5 > service/pom.xml afa52cf > service/src/java/org/apache/hive/service/cli/operation/Operation.java > d13415e > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > b0bd351 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 8b42265 > service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java > 1ab5652 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 2d784f0 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > d11cf3d > service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2 > service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION > service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION > service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css > PRE-CREATION > service/src/resources/hive-webapps/static/css/bootstrap.min.css > PRE-CREATION > service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION > > service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot > PRE-CREATION > > service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg > PRE-CREATION > > service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf > PRE-CREATION > > service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff > PRE-CREATION > service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION > > Diff: https://reviews.apache.org/r/40500/diff/ > > > Testing > ------- > > > Thanks, > > Jimmy Xiang > >
