----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40827/#review108599 -----------------------------------------------------------
Gooks lood to me. +1 - pengcheng xiong On Dec. 1, 2015, 7:03 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40827/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 7:03 p.m.) > > > Review request for hive, Prasanth_J and pengcheng xiong. > > > Bugs: HIVE-12491 > https://issues.apache.org/jira/browse/HIVE-12491 > > > Repository: hive-git > > > Description > ------- > > Better heuristic for ndv computations of functions. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > a8ff158 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 71ed31c > ql/src/test/results/clientpositive/cbo_rp_auto_join0.q.out 7822ad9 > ql/src/test/results/clientpositive/tez/explainuser_1.q.out a3d1f87 > > Diff: https://reviews.apache.org/r/40827/diff/ > > > Testing > ------- > > Existing tests. > > > Thanks, > > Ashutosh Chauhan > >