> On Dec. 2, 2015, 6:41 a.m., Mohit Sabharwal wrote: > > common/src/java/org/apache/hive/http/HttpServer.java, line 280 > > <https://reviews.apache.org/r/40833/diff/1/?file=1149773#file1149773line280> > > > > Nit: b.keyStorePath to determine ssl is not enabled looks bit unclean. > > Maybe add a useSsl boolean to the builder ?
Ok. > On Dec. 2, 2015, 6:41 a.m., Mohit Sabharwal wrote: > > common/src/java/org/apache/hive/http/HttpServer.java, line 311 > > <https://reviews.apache.org/r/40833/diff/1/?file=1149773#file1149773line311> > > > > Any reason why it shouldn't just default to what's specified in > > HiveConf.HIVE_SERVER2_WEBUI_MAX_THREADS (which is 50) ? It is because this HttpServer can be used for HMS web UI too. I changed the logic a little so that we don't hardcode the number here. > On Dec. 2, 2015, 6:41 a.m., Mohit Sabharwal wrote: > > common/src/java/org/apache/hive/http/HttpServer.java, line 302 > > <https://reviews.apache.org/r/40833/diff/1/?file=1149773#file1149773line302> > > > > Add back the comment > > > > /* Set servlet context attribute that can be used in jsp */ > > > > It wasn't clear to me this is related to jsp Added it to setContextAttributes method. You can take a look the jsp file to see how it is used. Basically, this is a way to pass information to jsp page. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40833/#review108613 ----------------------------------------------------------- On Dec. 1, 2015, 6:50 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40833/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 6:50 p.m.) > > > Review request for hive, Lefty Leverenz, Szehon Ho, and Xuefu Zhang. > > > Bugs: HIVE-12471 > https://issues.apache.org/jira/browse/HIVE-12471 > > > Repository: hive-git > > > Description > ------- > > This patch changed the HttpServer construction to use builder which is > flexible. It addes 3 configurations for web UI SSL support. By default, it is > disabled. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 9e805bd > common/src/java/org/apache/hive/http/HttpServer.java 1ff8d7c > service/src/java/org/apache/hive/service/server/HiveServer2.java 204eb5a > > Diff: https://reviews.apache.org/r/40833/diff/ > > > Testing > ------- > > Tested web UI with and without SSL, both work as expected. > > > Thanks, > > Jimmy Xiang > >
