> On Dec. 1, 2015, 8:34 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2460-2470 > > <https://reviews.apache.org/r/40365/diff/3-4/?file=1127596#file1127596line2460> > > > > [..].connection.timeout.ms: Is "before" correct in "before a failure" > > or should it be "Timeout (in milliseconds) after a connection failure ..."? > > > > Hm, I must be confused because the next parameter seems to cover that > > case -- [..].sleep.between.retries. > > Lefty Leverenz wrote: > I still don't understand what the task communicator connection timeout is > (or how you'd have a timeout _before_ a failure), but if you're satisfied > with the current description then it's okay with me.
Sergey explained in the JIRA comments: "One is the standard connection timeout before we give up and there's a failure, the other is a wait interval before retrying." Now I understand. - Lefty ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40365/#review108464 ----------------------------------------------------------- On Dec. 2, 2015, 3:41 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40365/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 3:41 a.m.) > > > Review request for hive, Lefty Leverenz and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 9e805bd > data/conf/llap/llap-daemon-site.xml f2851a7 > > llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java > bd09024 > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java > 34e0682 > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java > a8e1465 > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java > d474b6f > llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java > 317fa20 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java > 6d54fd4 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > 4b28b53 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java > 98b1ccd > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java > bc18a77 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java > 2db2833 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java > 9520413 > > llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java > d327fc0 > > llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java > 33e998c > > llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java > e920f86 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java > 4525ab9 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java > 8d45c95 > > llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java > 23724a4 > > Diff: https://reviews.apache.org/r/40365/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
