----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40948/ -----------------------------------------------------------
(Updated Dec. 4, 2015, 10:35 p.m.) Review request for hive. Changes ------- Adds some more test coverage, also fixes to the timer thread (give it a name, make it be able to be turned off). Bugs: HIVE-12499 https://issues.apache.org/jira/browse/HIVE-12499 Repository: hive-git Description ------- Add separate timer thread that polls for count of database, table, partition entries to publish as metrics, the period is configurable. Delay in getting exact number should be ok as this is for monitoring. Implemented for HBase and DB metastores. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java 95e2bcf common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 4d881ba common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java fd420f7 itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMetrics.java f571c7c itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseMetastoreMetrics.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 00602e1 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1c0ab6d metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 5b36b03 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java 2fb3e8f metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 98e6c75 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 9a1d159 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 8dde0af Diff: https://reviews.apache.org/r/40948/diff/ Testing ------- Added unit tests for HBase and Db metastores. Thanks, Szehon Ho