----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40976/#review109223 -----------------------------------------------------------
Patch looks good to me. But I also find some other similar places where we could use TS. Could you please double check them? Thanks. GenMRProcContext.java L98: List<Operator<? extends OperatorDesc>> listTopOperators GenMapRedUtils.java L769: topOp GenMapRedUtils.java L1538: topOp GenMRUnion1.java L173: topOp ParseContext.java L71: topOps (may need some more check) RewriteGBUsingIndex.java L233: L235 topTables RewriteQueryUsingAggregateIndexCtx.java L164: L215 topOps ExprProcFactory.java L176: topOp NullScanTaskDispatcher.java L168: topOperators SimpleFetchOptimizer.java L96 SemanticAnalyzer.java L243: topOps and following references - pengcheng xiong On Dec. 7, 2015, 6:37 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40976/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 6:37 p.m.) > > > Review request for hive and pengcheng xiong. > > > Bugs: HIVE-12595 > https://issues.apache.org/jira/browse/HIVE-12595 > > > Repository: hive-git > > > Description > ------- > > It seems like there are lot of usage of abstract Operator class where only > possibility is TableScanOp. This results in lot of uncertainty when that > parameter is passed in and is littered with instanceOf checks all over. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java dcdc9ba > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRProcContext.java > 0da5790 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java > af0ac90 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 0cd7b62 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinFactory.java 647f863 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinFactory.java > aca0630 > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 27d7276 > ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkUtils.java > 40c23a5 > ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 73e8f6d > ql/src/test/org/apache/hadoop/hive/ql/parse/TestGenTezWork.java d9ab9c0 > > Diff: https://reviews.apache.org/r/40976/diff/ > > > Testing > ------- > > Refactoring patch. Regression suite suffice. > > > Thanks, > > Ashutosh Chauhan > >
