> On Dec. 7, 2015, 9:45 p.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2349-2350 > > <https://reviews.apache.org/r/41017/diff/2/?file=1155340#file1155340line2349> > > > > "an unique" should be "a unique" -- this is a weirdness of the English > > language, a/an is based on pronunciation instead of spelling and "unique" > > sounds like it starts with the consonant Y. > > > > Also, FS could be spelled out although the meaning is obvious from > > context. I recommend leaving it as FS, but it's your choice. > > > > "we are unable" should be "Hive is unable" (or "LLAP is unable" > > perhaps) just to set a more formal tone, but I won't whine if you leave it > > as is.
+1 - Lefty ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41017/#review109191 ----------------------------------------------------------- On Dec. 8, 2015, 1:37 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41017/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 1:37 a.m.) > > > Review request for hive, Prasanth_J and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 > data/conf/hive-site.xml 2ebb1c4 > data/conf/llap/hive-site.xml 9440611 > data/conf/llap/llap-daemon-site.xml cc3e438 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 885acc0 > llap-server/src/test/resources/llap-daemon-site.xml ee240a9 > ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java 38c99fd > ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java 2275188 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetadataReaderImpl.java > 5afba51 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java f6dea25 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 7f550a4 > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/SettableUncompressedStream.java > eaf4fcc > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java > a8b51b9 > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java > 567214f > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java 698632b > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java > 7b3c2a0 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/StreamUtils.java > 814697d > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestBitFieldReader.java > 9e73700 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestBitPack.java 5843a05 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInStream.java ade959b > > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestIntegerCompressionReader.java > 8e42a05 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestRunLengthByteReader.java > 9c8e5b5 > > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestRunLengthIntegerReader.java > 9254101 > > Diff: https://reviews.apache.org/r/41017/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
