----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41535/#review111116 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java (line 229) <https://reviews.apache.org/r/41535/#comment171100> This doesn't give much information to the user. In explain, showing just LLAP IO: enabled or disabled should be enough. Alternatively, 3 states can be printed. FULL, PARTIAL and NONE. FULL meaning all partitions are non-ACID or ACID with only base files. PARTIAL is some ACID partitions with base files and some ACID partitions with delta. NONE is all ACID directories with delta. Other information can go to logs. Also this block of code is very hard to read. ql/src/test/results/clientpositive/llap_acid.q.out (line 108) <https://reviews.apache.org/r/41535/#comment171101> Doesn't really convey much to the user. - Prasanth_J On Dec. 18, 2015, 12:24 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41535/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 12:24 a.m.) > > > Review request for hive and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java > b57366c > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ColumnVectorProducer.java > 5c34fa3 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java > 259c483 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 5957d57 > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 24137e2 > ql/src/java/org/apache/hadoop/hive/ql/io/LlapAwareSplit.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61cde41 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 5803a9c > ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 73e8f6d > ql/src/test/queries/clientpositive/llap_acid.q PRE-CREATION > ql/src/test/results/clientpositive/llap_acid.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/41535/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
