> On Dec. 19, 2015, 2 a.m., Siddharth Seth wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java, > > line 89 > > <https://reviews.apache.org/r/41377/diff/2/?file=1171441#file1171441line89> > > > > Why is this required ? > > > > and why not in the single thread case.
some part of Tez init in Hive accesses the session. The single thread has it set; we just propagate it to other threads. > On Dec. 19, 2015, 2 a.m., Siddharth Seth wrote: > > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java, > > line 124 > > <https://reviews.apache.org/r/41377/diff/2/?file=1171443#file1171443line124> > > > > Is there any part of the test which verifies that threads are being > > used / sessions are being setup in parallel. Not sure if there's a good way > > to verify that though - without setting up explicit properties for tests > > only. No. Rather, I saw the order change in the other test, that's how I know it works :) - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41377/#review111342 ----------------------------------------------------------- On Dec. 18, 2015, 10:10 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41377/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 10:10 p.m.) > > > Review request for hive, Gunther Hagleitner and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 36e281a > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java 6e196e6 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > 0d84340 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java e1a8041 > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java > 11c0325 > > Diff: https://reviews.apache.org/r/41377/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
