[ 
https://issues.apache.org/jira/browse/HIVE-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143225#comment-13143225
 ] 

jirapos...@reviews.apache.org commented on HIVE-2178:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1978/
-----------------------------------------------------------

(Updated 2011-11-03 14:59:09.059591)


Review request for hive, Carl Steinbach and John Sichi.


Changes
-------

Patch become stale so rebased the patch


Summary
-------

Fixed Log related Check style Comments like including root exception and adding 
messages.


This addresses bug HIVE-2178.
    https://issues.apache.org/jira/browse/HIVE-2178


Diffs (updated)
-----

  trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 1197152 
  trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java 1197152 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1197152 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 1197152 
  
trunk/serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/SimpleCharStream.java
 1197152 
  
trunk/serde/src/java/org/apache/hadoop/hive/serde2/thrift/TBinarySortableProtocol.java
 1197152 

Diff: https://reviews.apache.org/r/1978/diff


Testing
-------

Ran all unit tests


Thanks,

chinna


                
> Log related Check style Comments fixes
> --------------------------------------
>
>                 Key: HIVE-2178
>                 URL: https://issues.apache.org/jira/browse/HIVE-2178
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise 
> Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2178.1.patch, HIVE-2178.2.patch, HIVE-2178.3.patch, 
> HIVE-2178.4.patch, HIVE-2178.5.patch, HIVE-2178.patch
>
>
> Fix Log related Check style Comments

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to