----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/#review113017 -----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/CLIService.java (line 48) <https://reviews.apache.org/r/41928/#comment173513> Avoid of the move of import statements service/src/java/org/apache/hive/service/cli/CLIService.java (line 206) <https://reviews.apache.org/r/41928/#comment173514> Comment does not make sense. Please add proper javadoc Please add unit tests - Amareshwari Sriramadasu On Jan. 5, 2016, 3:12 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41928/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 3:12 p.m.) > > > Review request for hive. > > > Bugs: HIVE-12777 > https://issues.apache.org/jira/browse/HIVE-12777 > > > Repository: hive-git > > > Description > ------- > > Extensions using Hive session handles should be able to restore the hive > session from the handle. > > Apache Lens depends on a fork of hive and that fork has such a capability. > > Relevant commit: > https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be > > > Diffs > ----- > > service/src/java/org/apache/hive/service/cli/CLIService.java > adc98098437b2d0429dd2af40d8eaae323fbf3f0 > service/src/java/org/apache/hive/service/cli/SessionHandle.java > 52e0ad4834d8b44d5038bb5c1a851eb702cd38ca > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 50c912ee606bce73f447fba69ce0f57d8c7fc6c9 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 637cdca3bcea9d320f397de032fd78d59ce6afef > > Diff: https://reviews.apache.org/r/41928/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
