----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42134/#review113961 -----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/OperationStatus.java (line 45) <https://reviews.apache.org/r/42134/#comment174742> Can you add test for validating task status values ? - Amareshwari Sriramadasu On Jan. 12, 2016, 8:45 a.m., Akshay Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42134/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 8:45 a.m.) > > > Review request for hive and Amareshwari Sriramadasu. > > > Bugs: HIVE-4570 > https://issues.apache.org/jira/browse/HIVE-4570 > > > Repository: hive-git > > > Description > ------- > > Driver maintains list of running and runnable tasks although that info is not > exposed outside. It's kept locally in the driver's execute method. We can add > Driver.getTaskStatuses() to return status on all tasks (both running and > runnable). Similarly, start and completion times for operations. > > Proposed changes are : > > struct TGetOperationStatusResp { > 1: required TStatus status > 2: optional TOperationState operationState > > // If operationState is ERROR_STATE, then the following fields may be set > // sqlState as defined in the ISO/IEF CLI specification > 3: optional string sqlState > > // Internal error code > 4: optional i32 errorCode > > // Error message > 5: optional string errorMessage > > // List of statuses of sub tasks > 6: optional string taskStatus > > // When was the operation started > 7: optional i64 operationStarted > // When was the operation completed > 8: optional i64 operationCompleted > > } > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 29e6315 > ql/src/java/org/apache/hadoop/hive/ql/TaskStatus.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 0eab63e > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ab7fd93 > service/if/TCLIService.thrift baf583f > service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828 > > service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java > 8868ec1 > > service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java > 8ecdc2e > > service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java > 6df1e8a > > service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java > e56686a > > service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java > a09b39a > > service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java > 740b851 > > service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java > 2a0fec2 > > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java > 04dc6e3 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > d2b3f9c > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 2eaab4a > > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java > 1af4539 > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a > > Diff: https://reviews.apache.org/r/42134/diff/ > > > Testing > ------- > > > Thanks, > > Akshay Goyal > >
