> On Jan. 11, 2016, 11:05 p.m., pengcheng xiong wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java, line > > 226 > > <https://reviews.apache.org/r/42081/diff/3/?file=1190420#file1190420line226> > > > > The patch looks good to me. +1. Could you put the reason that we > > discussed before here so that people will have a better understanding? And > > also please list the future work to improve it. Thanks. > > Chaoyu Tang wrote: > This patch is going to address the critical data incorrect issue in a > union with aggregate function when stats optimization is enabled. It bails > out the query stats optimization if any of its branch is not able to be. A > followed up JIRA HIVE-12840 has been opened to investigate the solution as > Pengcheng suggested to leverage stats optimizer whenever possible (even only > for a branch of a union). See our detailed discussion in HIVE-12788.
Pengcheng, I wonder above comment is sufficient, if yes, could you also +1 in the JIRA? Thanks. - Chaoyu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42081/#review113865 ----------------------------------------------------------- On Jan. 10, 2016, 2:17 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42081/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2016, 2:17 p.m.) > > > Review request for hive, Ashutosh Chauhan, pengcheng xiong, and Xuefu Zhang. > > > Bugs: HIVE-12788 > https://issues.apache.org/jira/browse/HIVE-12788 > > > Repository: hive-git > > > Description > ------- > > adds StatsOptimizator support to union with aggregate function. Otherwise, it > always returns one row. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 03c1c3f > ql/src/test/queries/clientpositive/union_remove_26.q PRE-CREATION > ql/src/test/results/clientpositive/union_remove_26.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/42081/diff/ > > > Testing > ------- > > 1. Manual tests for some partitcular cases > 2. submitted to precommit-tests > > > Thanks, > > Chaoyu Tang > >
