-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42286/#review114825
-----------------------------------------------------------



llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java
 (line 63)
<https://reviews.apache.org/r/42286/#comment175671>

    You're initializing the classloader with the thread's current context class 
loader. Is it possible the current class loader has loaded other JARs from some 
previous initialization or query?



llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java
 (line 65)
<https://reviews.apache.org/r/42286/#comment175894>

    I see you have created a work queue to handle localization of resources and 
updating the classloader. Is there any mechanism in place to make sure nothing 
else is using the classloader while it is being refreshed?


- Jason Dere


On Jan. 16, 2016, 12:09 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42286/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 12:09 a.m.)
> 
> 
> Review request for hive and Jason Dere.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1e8c34b 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
>  0d85671 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java
>  PRE-CREATION 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 
> ddedfbf 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
>  34aa5c9 
>   
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestTaskExecutorService.java
>  5491064 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java ec755a8 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java dca1198 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java 
> af6129a 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c38699d 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java 
> 25c2ff3 
>   ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java 
> 7289426 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5f15557 
>   ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/util/DosToUnix.java 4480d54 
>   ql/src/java/org/apache/hadoop/hive/ql/util/ResourceDownloader.java 
> PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/session/TestAddResource.java 1f07235 
> 
> Diff: https://reviews.apache.org/r/42286/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Reply via email to