> On Jan. 20, 2016, 10:18 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java, > > line 263 > > <https://reviews.apache.org/r/42359/diff/2/?file=1202090#file1202090line263> > > > > Do we really need to find uniqueness of expression? > > Can we do numKeys = joinLeafPredInfo.getJoinExprs(i).size() ?
Makes sense, apparently joinKeyExprs themselves are implemented using ImmutableSet which takes care of duplicates. Have made change in the next patch upload. - Hari Sankar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42359/#review115499 ----------------------------------------------------------- On Jan. 19, 2016, 9 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42359/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 9 p.m.) > > > Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and John > Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > HIVE-12805 CBO: Calcite Operator To Hive Operator (Calcite Return Path): > MiniTezCliDriver skewjoin.q failure > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java > 660f01d > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInsertExchange4JoinRule.java > d6e3915 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java > 5d169a1 > > Diff: https://reviews.apache.org/r/42359/diff/ > > > Testing > ------- > > Clean precommit > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
