----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42777/#review116491 -----------------------------------------------------------
LGTM. Few minor comments. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1906) <https://reviews.apache.org/r/42777/#comment177507> nit: "max old" -> "maximum number of past operations to show in HiverSever2 WebUI." service/src/java/org/apache/hive/service/cli/operation/Operation.java (line 94) <https://reviews.apache.org/r/42777/#comment177508> nit: beginTime = lastAccessTime; service/src/java/org/apache/hive/service/cli/operation/OperationManager.java (line 71) <https://reviews.apache.org/r/42777/#comment177510> extra line service/src/java/org/apache/hive/service/cli/operation/OperationManager.java (line 341) <https://reviews.apache.org/r/42777/#comment177506> check for getSQLOperationInfo() returning null here. - Mohit Sabharwal On Jan. 26, 2016, 10:26 p.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42777/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 10:26 p.m.) > > > Review request for hive. > > > Bugs: HIVE-12550 > https://issues.apache.org/jira/browse/HIVE-12550 > > > Repository: hive-git > > > Description > ------- > > Use a Guava 'EvictingQueue' to cache finished SQLOperation info. Bump up > Guava version to get this. The information is saved when the SQLOperation is > closed. > > Also fix a small discrepancy where Elapsed Time (existing field) was > comparing against lastAccessTime , which gets updated whenever state changes > and some other places. Chaged to compare against operation's start time. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 97fe7bc > pom.xml 2066518 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 75187cf > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 113eddf > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 92135cd > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > c8a69b9 > > service/src/java/org/apache/hive/service/cli/operation/SQLOperationInfo.java > PRE-CREATION > service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp a91b008 > > Diff: https://reviews.apache.org/r/42777/diff/ > > > Testing > ------- > > Manual testing, with screenshot attached. > > > Thanks, > > Szehon Ho > >
