----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42960/#review117538 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 513) <https://reviews.apache.org/r/42960/#comment178749> I think there is a materialized table lifecycle problem. 1. What if there is already a table by that name (temp/regular) 2. CTE Temp table should be cleaned up at the end of the container query (successful/non successful execution) - John Pullokkaran On Feb. 1, 2016, 4:36 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42960/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 4:36 p.m.) > > > Review request for hive, Ashutosh Chauhan, John Pullokkaran, and Navis Ryu. > > > Bugs: HIVE-11752 > https://issues.apache.org/jira/browse/HIVE-11752 > > > Repository: hive-git > > > Description > ------- > > Pre-materializing complex CTE queries > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > ff376a853b7d89262157de67e355b22b941aeebe > ql/src/java/org/apache/hadoop/hive/ql/Context.java > 746456bf39d1a5d700b42d3e0f2c0dcd4001e1ad > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > 4c89812403f65c7d4beae37952dafc42f44c1519 > ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java > 9132a212f8bd3600467c4337a0562b1e64bed908 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > 2e4591313f38d9bd1bfe1b54968c835fdcd53717 > ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java > 40c89cb9681567a18181514cbffc497e0b2f937e > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java > a5217eb2781dba7f1f35a8a1f87e6784c7ea59ef > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > 46bf04c738917e2c3d9f186319fea6f6f2811d3f > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > af1ee20a8636523a77b45bf596daddb1330b09d5 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > e2d404b0bd1d3916e498bc4c4076cdf168ef2272 > ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java > e1e3eb23f13591114153ec5810a0d6c28245085d > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezProcContext.java > ec5ef0eb2be9bde851c70cddbb167a7dc30c78c3 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 607c2f32e00d3d62636fd99c8864ed5bcf24b53b > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java > 89897d7e5805e05903181f9c202852a9bfdba552 > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java > 2c6bb217ec880bcc1d4a1cf3c6c891cf779cff52 > ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java > cc462bea07e371629a94e809dba910625cc68508 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java > ea506fc13f6a69600e850b4cdcb7a62f613af8b7 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestGenTezWork.java > be51edc49581f881a4a92b464e0323bf7661b17f > ql/src/test/queries/clientpositive/cte_3.q PRE-CREATION > ql/src/test/queries/clientpositive/cte_4.q PRE-CREATION > ql/src/test/queries/clientpositive/cte_mat_1.q PRE-CREATION > ql/src/test/queries/clientpositive/cte_mat_2.q PRE-CREATION > ql/src/test/queries/clientpositive/cte_mat_3.q PRE-CREATION > ql/src/test/results/clientnegative/analyze1.q.out > 589a6ee1bfe9429e5250f5b78202d7aa586b6973 > ql/src/test/results/clientnegative/dyn_part1.q.out > 62d01fbef8af967474127e2d5f00bd6d2f4858d7 > ql/src/test/results/clientpositive/alter_view_as_select.q.out > c89c0dc8602716ad4247208cfaefbab1eabec8e6 > ql/src/test/results/clientpositive/cte_3.q.out PRE-CREATION > ql/src/test/results/clientpositive/cte_4.q.out PRE-CREATION > ql/src/test/results/clientpositive/cte_mat_1.q.out PRE-CREATION > ql/src/test/results/clientpositive/cte_mat_2.q.out PRE-CREATION > ql/src/test/results/clientpositive/cte_mat_3.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/tez_union.q.out > f5cd30fdaf5794d9320a0ff3a7474840e2dc3a92 > ql/src/test/results/clientpositive/tez/tez_union.q.out > 8baa5cf6feae021bbf02d60dc5d5c80692160e53 > > Diff: https://reviews.apache.org/r/42960/diff/ > > > Testing > ------- > > Existing plus additional q tests. > > > Thanks, > > Jesús Camacho Rodríguez > >
