----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40415/#review119116 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java (line 2230) <https://reviews.apache.org/r/40415/#comment180526> nit: use single arg ctor instead? metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java (line 2255) <https://reviews.apache.org/r/40415/#comment180527> nit: same as above. use 2 arg ctor instead? metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java (line 1523) <https://reviews.apache.org/r/40415/#comment180528> Then why provide this interface? Is it client's responsibility as to when to use this interface? ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java (line 484) <https://reviews.apache.org/r/40415/#comment180529> Is it intentional? Stacktrace will be lost. ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java (line 41) <https://reviews.apache.org/r/40415/#comment180533> what is the byteBuffer arg contain? What is the return type? It's unclear from the function signature. I think it will be better to do the conversion from SplitInfo to ByteBuffer just right before we send it across the wire. SplitInfo can be generic across file formats. ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 625) <https://reviews.apache.org/r/40415/#comment180530> nit. are there multiple caches? ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 998) <https://reviews.apache.org/r/40415/#comment180531> same as above. is it required to drop the stacktrace and just print the message? ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2002) <https://reviews.apache.org/r/40415/#comment180657> OrcInputFormat is becoming the next SemanticAnalyzer. Too many inner classes/interfaces. :) ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 2312) <https://reviews.apache.org/r/40415/#comment180380> In general, ORC PPD is controlled by hive.optimizer.index.filter config. If this config is disabled, we should disable metastore footer cache ppd as well. - Prasanth_J On Feb. 12, 2016, 2:58 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40415/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2016, 2:58 a.m.) > > > Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cd17a84 > > metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java > bd4e188 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 564fca4 > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 07c20bf > > metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java > 1b388aa > orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 520ae74 > ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java > ef76723 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java f36f707 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java a92c002 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java > 9b1d7ae > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java > 7a93b54 > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java > dc71db4 > > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java > be5e67b > > Diff: https://reviews.apache.org/r/40415/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
