----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44664/#review122951 -----------------------------------------------------------
Should we add some q-test on encryption_drop_partition.q for external table/partitions as well? - Sergio Pena On March 10, 2016, 5:39 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44664/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 5:39 p.m.) > > > Review request for hive and Sergio Pena. > > > Bugs: HIVE-13243 > https://issues.apache.org/jira/browse/HIVE-13243 > > > Repository: hive-git > > > Description > ------- > > If the drop is for an external table, there is no need to check the > Trash/Purge when deleting a file in encryption zone since no delete occurs > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 0e8a157 > ql/src/test/queries/clientpositive/encryption_drop_table.q 193beea > ql/src/test/results/clientpositive/encrypted/encryption_drop_table.q.out > 55eefa0 > > Diff: https://reviews.apache.org/r/44664/diff/ > > > Testing > ------- > > Manual test > New unit test > Precommit build test > > > Thanks, > > Chaoyu Tang > >