----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44524/#review123098 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java (line 41) <https://reviews.apache.org/r/44524/#comment185243> Can you add unit test? serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java (line 53) <https://reviews.apache.org/r/44524/#comment185244> Can you add unit test? serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java (line 531) <https://reviews.apache.org/r/44524/#comment185245> Can you add unit test? - Amareshwari Sriramadasu On March 8, 2016, 7:17 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44524/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 7:17 p.m.) > > > Review request for hive and Amareshwari Sriramadasu. > > > Bugs: HIVE-11484 > https://issues.apache.org/jira/browse/HIVE-11484 > > > Repository: hive-git > > > Description > ------- > > Fixed ObjectInspectorConverter and Java ObjectInspector for Char and Varchar > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java > 3514726 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java > f429709 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java > a8e34ff > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java > 5eb41d5 > > Diff: https://reviews.apache.org/r/44524/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Deepak Barr > >
